or replace the 'while' block with

SET @thestring = REPLICATE(@padchar, @finlength-LEN(RTRIM(@thestring))) + @thestring

It very much depends on whereabouts in the world you are. '10/10/2004' is unambiguous, but '9/10/2004' could be the 9th of October in Britain or the 10th of September in...