October 24, 2012 at 3:41 pm
The below query has to give Y if it's equals to zero but it gives always zero. can you modify this one
UPDATE T1 SET [coumnname] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName] IS NOT NULL AND [colname2] <> 0 THEN 'Y' ELSE 'N' END
FROM tablename T1
LEFT JOIN tablename2 T2 ON (T1.[Application ID] = T2.[Application ID] AND T1.[ServerName] = T2.[ServerName]) WHERE T2.[Data Period] = 'September 2012'
October 24, 2012 at 3:56 pm
This one says if the tested column is NOT = 0, then it will update with a 'y'. Your post isn't really clear about what the actual results of the update are.
October 24, 2012 at 4:00 pm
There's not much we can do without DDL and sample data.
To audit the problem, you could do a simple select instead of the update.
Another thing to watch is the datatype. You can't expect to return 'Y' if the data type is int.
--This first line will return an error
--UPDATE tablename SET = 'N'
--Commenting the UPDATE to transform into SELECT
--UPDATE T1 SET
-- [coumnname] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName] IS NOT NULL AND [colname2] <> 0 THEN 'Y' ELSE 'N' END
SELECT T2.[Application ID], --It's recommended not to use spaces for column/object names
T2.[ServerName],
colname2
FROM tablename T1
LEFT JOIN tablename2 T2 ON (T1.[Application ID] = T2.[Application ID] AND T1.[ServerName] = T2.[ServerName])
WHERE T2.[Data Period] = 'September 2012'
--Uncomment to be sure there're records that comply
--AND T2.[Application ID] IS NOT NULL
--AND T2.[ServerName] IS NOT NULL
--AND [colname2] <> 0
October 24, 2012 at 4:02 pm
Please check this below one more time ...i give clearly
UPDATE T1 SET [September 2012 Billing File] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName]
IS NOT NULL AND [TB Billed This Month] <> 0 THEN 'Y' ELSE 'N' END
FROM TableName1 T1
LEFT JOIN TableName2 T2 ON (T1.[Application ID] = T2.[Application ID]
AND T1.[ServerName] = T2.[ServerName]) WHERE T2.[Data Period] = 'September 2012'
October 24, 2012 at 4:10 pm
Please check this below one more time ...i give clearly
It is taking the one first row it should be take entire rows.
UPDATE T1 SET [September 2012 Billing File] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName]
IS NOT NULL AND [TB Billed This Month] <> 0 THEN 'Y' ELSE 'N' END
FROM TableName1 T1
LEFT JOIN TableName2 T2 ON (T1.[Application ID] = T2.[Application ID]
AND T1.[ServerName] = T2.[ServerName]) WHERE T2.[Data Period] = 'September 2012'
October 24, 2012 at 4:11 pm
Were trying to point out that since we do not have your tables or data we cannot tell you why the case is evaluating to N
Before running your update,
Run a version of the query as a select statement.
Are the data elements in your query evaluating as you suspect?
Is T2.Application ID Not Null? Is ServerName Not Null?
and does TB Billed This Month Not equal 0?
SELECT
T2.[Application ID]
, T2.[ServerName]
,[TB Billed This Month]
,CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName] IS NOT NULL AND [TB Billed This Month] <> 0 THEN 'Y' ELSE 'N' END
FROM TableName1 T1
LEFT JOIN TableName2 T2 ON (T1.[Application ID] = T2.[Application ID]
AND T1.[ServerName] = T2.[ServerName]) WHERE T2.[Data Period] = 'September 2012'
October 24, 2012 at 4:13 pm
OK, this code:
UPDATE T1 SET [September 2012 Billing File] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName]
IS NOT NULL AND [TB Billed This Month] <> 0 THEN 'Y' ELSE 'N' END
FROM TableName1 T1
LEFT JOIN TableName2 T2 ON (T1.[Application ID] = T2.[Application ID]
AND T1.[ServerName] = T2.[ServerName]) WHERE T2.[Data Period] = 'September 2012'
will set [September 2012 Billing File] = 'y' if [TB Billed This Month] IS NOT = 0. If you want it to set [September 2012 Billing File] = 'y' if [TB Billed This Month] = 0 the the '<> 0' in your code needs to change to '= 0'.
October 24, 2012 at 4:54 pm
2 possible things
The query is returning multiple rows, and the 'N' is being returned because of the last row.
OR/AND
Your performing a Left Join,
But you referencing T2.[Date Period] in your Where clause effectively makings it an inner join.
Unless the the value for Application ID and Server Name are NULL in the T2 table It will never evaluate to 'Y'
This is why we need sample data and DDL which would allow us to see these things and provide a better answer.
SELECT
T2.[Application ID]
, T2.[ServerName]
,[TB Billed This Month]
,CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName] IS NOT NULL AND [TB Billed This Month] <> 0 THEN 'Y' ELSE 'N' END
FROM TableName1 T1
LEFT JOIN TableName2 T2 ON (T1.[Application ID] = T2.[Application ID]
AND T1.[ServerName] = T2.[ServerName]) WHERE T2.[Data Period] = 'September 2012'
October 24, 2012 at 5:18 pm
Awesome......I use inner join instead of Left join
Now its working fyn...Thank you very much
October 24, 2012 at 8:55 pm
Hi..Once again thanks for all your support. but my lead ask me to modify the query like below. I tried it but it giving error. Could any one modify it plzzz
Msg 8120, Level 16, State 1, Line 1
Column 'AEG_DB.dbo.MRO_TBL_EMCData.Application ID' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.
select [September 2012 Billing File] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName]
IS NOT NULL AND Sum([Billed This Month]) <> 0 THEN 'Y' ELSE 'N' END
FROM [AEG_DB].[dbo].[TBL_Work] T1
LEFT JOIN [TBL_Data] T2 ON (T1.[Application ID] = T2.[Application ID] AND T1.[ServerName] = T2.[ServerName])
WHERE T2.[Data Period] = 'September 2012'
October 25, 2012 at 6:47 am
The error says you tried to select a column which was not mentioned in the 'group by'. Post data and the complete query please!
https://sqlroadie.com/
October 25, 2012 at 8:23 am
You cannot sum in this manner,
So you should do the sum in a derived table.
and Once again you were trying to left join to t2 but if you have a value in the where clause that references c2 it makes it an inner join.
Edit: Fixed Typos
SELECT [September 2012 Billing File] = CASE WHEN T2.[Application ID] IS NOT NULL AND T2.[ServerName]
IS NOT NULL AND ISNULL(t2.[Billed This Month],0) <> 0 THEN 'Y' ELSE 'N' END
FROM [AEG_DB].[dbo].[TBL_Work] T1
LEFT JOIN (SELECT SUM(i.[Billed This Month]) AS [Billed This Month], i.[ServerName], i.[Application ID]
FROM [TBL_Data] i
WHERE i.[Data Period] = 'September 2012'
GROUP BY i.[ServerName],
i.[Application ID]) T2
ON (T1.[Application ID] = T2.[Application ID] AND T1.[ServerName] = T2.[ServerName])
Viewing 12 posts - 1 through 11 (of 11 total)
You must be logged in to reply to this topic. Login to reply