Slow Stored Procedure run time

Question

Slow Stored Procedure run time

Chuck Craig-199542

SSC-Addicted

Points: 420
More actions
February 4, 2009 at 8:28 am

#204919

I have a SP that accepts 2 parms an Int and a Char(5).
EXEC@return_value = [dbo].[_Chuck]
@PlanID = 2,
@Fiscalyear = N'08/09'
SELECT'Return Value' = @return_value
When I run the SP it takes 2min 45 sec to complete
If I take the Char(5) out as a Parm and place it into the SP with a
Declare @Fiscalyear CHAR(5)
SET @Fiscalyear = '08/09'
the Sp runs in 9 seconds.
Of course I can't set it up the way as I need the char(5) to be variable.
I know i haven't posted any code, and I will if the group feels it would help
Cheers
Chuck

Viewing 6 posts - 1 through 5 (of 5 total)

You must be logged in to reply to this topic. Login to reply

ChrisM@Work SSC Guru Points: 186127 More actions · Answer 1

Chuck, run a search (on this forum) on parameter sniffing. If this is the problem, which seems likely, then the solution can be pretty straightforward.

Cheers

ChrisM

^{“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw}

For fast, accurate and documented assistance in answering your questions, please read this article.
Understanding and using APPLY, (I) and (II) Paul White
Hidden RBAR: Triangular Joins / The "Numbers" or "Tally" Table: What it is and how it replaces a loop Jeff Moden

Chuck Craig-199542 SSC-Addicted Points: 420 More actions · Answer 2

Chuck Craig-199542

SSC-Addicted

Points: 420

February 4, 2009 at 8:43 am

#938021

I'm on it and thanks!

Cheers

Chuck

Lowell SSC Guru Points: 323518 More actions · Answer 3

yep same issue as the post here:http://www.sqlservercentral.com/Forums/Topic649831-8-1.aspx

i put a decent explanation and fixes there.

Lowell

--help us help you! If you post a question, make sure you include a CREATE TABLE... statement and INSERT INTO... statement into that table to give the volunteers here representative data. with your description of the problem, we can provide a tested, verifiable solution to your question! asking the question the right way gets you a tested answer the fastest way possible!

ChrisM@Work SSC Guru Points: 186127 More actions · Answer 4

Lowell (2/4/2009)
yep same issue as the post here:http://www.sqlservercentral.com/Forums/Topic649831-8-1.aspx
i put a decent explanation and fixes there.

Top work Trinny, I was just about to post this one in.

^{“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw}

For fast, accurate and documented assistance in answering your questions, please read this article.
Understanding and using APPLY, (I) and (II) Paul White
Hidden RBAR: Triangular Joins / The "Numbers" or "Tally" Table: What it is and how it replaces a loop Jeff Moden

Chuck Craig-199542 SSC-Addicted Points: 420 More actions · Answer 5

Thank you all,

I've got it down to 13 seconds as it works through about 40M rows of data.

I placed new variables inline and assigned the passed parms to them.

The DBA's are also looking into wether statistics are correctly being updated.

But I'm thrilled!

Cheers

Chuck