Post reply

Remove SQL Comments

  • April 3, 2017 at 1:19 pm

    #336237

    Comments posted to this topic are about the item Remove SQL Comments

  • April 3, 2017 at 3:22 pm

    #1936428

    Just curious, why would you want to remove comments from your SQL code/scripts?

  • April 13, 2017 at 6:33 am

    #1938020

    Question: could this be combined somehow with Redgate's SQL Search tool.  Or (alternately) with a stored procedure that searches for a specified text string.  Goal here is to remove or ignore the 'false positives' that show up when I'm doing an impact analysis for an impending database upgrade.  References to said database show up in the comments or documentation section of a sproc, and I'd prefer (perhaps optionally) that those non-programmatic references be ignore.

  • April 13, 2017 at 7:12 am

    #1938031

    Lynn Pettis - Monday, April 3, 2017 3:22 PM

    Just curious, why would you want to remove comments from your SQL code/scripts?

    I've done this specifically when i'm searching the text of sys.sql_modules.definitions, looking for various things related to coding practices, but not references to objects.
    specifically, i have a similar procedure that strips comments, and then also all whitespace.

    now that text has no spaces,and i can search for coding patterns.
    if I find "SELECTTOP1" in any cleaned definition, there is an excellent chance that someone is using an inline query to get one column value, which is executed on a per row basis. I use that to replace it with a proper join and group by to fix performance.
    i can then check for exists /not exists for other things like whether "SETXACT_ABORTON" exists in the stripped clean Definition or not, and decide whether it should have been there..."NOCOUNTON" , "ASBEGIN" and so many other "better practices" that should exist but might be missing.

    also it makes it a bit easier to search for whehter @TableVariables where used, and i might want to replace with #temp tables, and index hints like nolock or merge/loop joins, etc.

    Lowell

    --help us help you! If you post a question, make sure you include a CREATE TABLE... statement and INSERT INTO... statement into that table to give the volunteers here representative data. with your description of the problem, we can provide a tested, verifiable solution to your question! asking the question the right way gets you a tested answer the fastest way possible!

  • April 13, 2017 at 8:52 am

    #1938077

    Nate Schmidt - Thursday, April 13, 2017 6:33 AM

    Question: could this be combined somehow with Redgate's SQL Search tool.  Or (alternately) with a stored procedure that searches for a specified text string.  Goal here is to remove or ignore the 'false positives' that show up when I'm doing an impact analysis for an impending database upgrade.  References to said database show up in the comments or documentation section of a sproc, and I'd prefer (perhaps optionally) that those non-programmatic references be ignore.

    That's a really good question. I can't speak to whether or not this can be incorporated into the Redgate tools. But searching database objects is the entire reason that I created this script in the first place. While Redgate's tools are awesome, the search tool isn't great when you need to run massive searches for many objects or many strings. So, when I have the function created, I can then write something like the code below. It's still possible to have false positives in something like a literal string, but this gets me 99% accurate results when searching for a certain table for example. 


    SELECT o.name, o.xtype    
    FROM    sys.sql_modules m            
    INNER JOIN sys.sysobjects o                
        ON m.object_id = o.id            
    WHERE    o.xtype IN ('P', 'V', 'TR', 'TF', 'FN', 'IF')    
        --AND m.definition LIKE '%Something%'    
        AND dbo.RemoveComments(m.definition) like '%something%'

Viewing 5 posts - 1 through 4 (of 4 total)

You must be logged in to reply to this topic. Login to reply