RBAR is a dog - woof! need performance improvement

Question

Post reply

RBAR is a dog - woof! need performance improvement

Viewing 5 posts - 16 through 19 (of 19 total)

You must be logged in to reply to this topic. Login to reply

Seggerman-675349 Hall of Fame Points: 3563 More actions · Answer 1

nope, I've nearly got it - thanks again for all your help

I'll post it when done, removing the PRINTs, sundry SELECTs of table variables, etc

Sean Lange SSC Guru Points: 286590 More actions · Answer 2

Seggerman-675349 (3/13/2014)
nope, I've nearly got it - thanks again for all your help
I'll post it when done, removing the PRINTs, sundry SELECTs of table variables, etc

You are quite welcome although I think the only help you received from was apparently becoming a muse. My posts were all just asking for details so I had an idea of what you are trying to do. I still have no idea what the actual code is supposed to do. I am glad you figured it out.

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter http://www.sqlservercentral.com/articles/Tally+Table/72993/.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns - http://www.sqlservercentral.com/articles/T-SQL/63681/
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs - http://www.sqlservercentral.com/articles/Crosstab/65048/
Understanding and Using APPLY (Part 1) - http://www.sqlservercentral.com/articles/APPLY/69953/
Understanding and Using APPLY (Part 2) - http://www.sqlservercentral.com/articles/APPLY/69954/

Seggerman-675349 Hall of Fame Points: 3563 More actions · Answer 3

here's the new proc - it ran the night before in 88 minutes

last night it took 4 minutes:w00t:

legal told me to take it down:(

Sean Lange SSC Guru Points: 286590 More actions · Answer 4

That looks better but you still have RBAR in there. You have a while loop that is still running but going from 88 minutes to 4 is a vast improvement. 😀

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter http://www.sqlservercentral.com/articles/Tally+Table/72993/.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns - http://www.sqlservercentral.com/articles/T-SQL/63681/
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs - http://www.sqlservercentral.com/articles/Crosstab/65048/
Understanding and Using APPLY (Part 1) - http://www.sqlservercentral.com/articles/APPLY/69953/
Understanding and Using APPLY (Part 2) - http://www.sqlservercentral.com/articles/APPLY/69954/

WayneS SSC Guru Points: 95460 More actions · Answer 5

You might want to consider replacing all of those table variables with temp tables. The results may surprise you.

Wayne
Microsoft Certified Master: SQL Server 2008
Author - SQL Server T-SQL Recipes

If you can't explain to another person how the code that you're copying from the internet works, then DON'T USE IT on a production system! After all, you will be the one supporting it!

Links:
For better assistance in answering your questions
Performance Problems
Common date/time routines
Understanding and Using APPLY Part 1 & Part 2