Are the posted questions getting worse?
-
Jeff Moden (10/26/2011)
jcrawf02 (10/26/2011)
what do you guys use for calendar apps?My failing memory! 😛 The cool part about it is, I don't have to go to so many meetings that way. :hehe:
Good Idea. Will you keep track of my appointments too?
Jason...AKA CirqueDeSQLeil
_______________________________________________
I have given a name to my pain...MCM SQL Server, MVP
SQL RNNR
Posting Performance Based Questions - Gail Shaw[/url]
Learn Extended Events -
jcrawf02 (10/26/2011)
what do you guys use for calendar apps?I use Google Calendar. I have a personal calendar and then there is a shared calendar for the family.
Jason...AKA CirqueDeSQLeil
_______________________________________________
I have given a name to my pain...MCM SQL Server, MVP
SQL RNNR
Posting Performance Based Questions - Gail Shaw[/url]
Learn Extended Events -
Gianluca Sartori (10/27/2011)
Strange coincidence!And it continues
Jason...AKA CirqueDeSQLeil
_______________________________________________
I have given a name to my pain...MCM SQL Server, MVP
SQL RNNR
Posting Performance Based Questions - Gail Shaw[/url]
Learn Extended Events -
WayneS (10/27/2011)
Kiara (10/27/2011)
Stefan Krzywicki (10/26/2011)
Kiara (10/26/2011)
Droid Bionic here. I have an iPad2 - and I just don't like it all that much.
What dont you like about it? Everyone I know that has one loves it, so I'd be interested in hearing a different opinion.
Sending you a PM, rather than clutter up the Thread...
Kiara, please reconsider. While I have and and really do like my iPad2, I am interested in seeing why those that don't like it don't. Plus, anything (except code and deep technical questions) are fair game on The Thread.
+1, I'd like to hear your thoughts too.
I purchased a domain for the family and set up a calendar for each family member and some for other items (holidays, "whole family" activities, etc.). I did it that way so that I could get categorization by color - each calendar has it's own color and I can tell at a glance who/where/what is going on. Helps the wife and I coordinate and make sure that we are both on the same page for what the family plan is. I have mine syncing to an iphone (provided by work, I didn't get to pick) and the wife has a droid. We've had some, but very few issues.
-
GSquared (10/27/2011)
Kiara (10/27/2011)
Sending you a PM, rather than clutter up the Thread...
The Thread lacks clutter???????????????????
Y'know, when I wrote that, I sort of shook my head at myself...
-Ki
-
Kiara (10/27/2011)
GSquared (10/27/2011)
Kiara (10/27/2011)
Sending you a PM, rather than clutter up the Thread...
The Thread lacks clutter???????????????????
Y'know, when I wrote that, I sort of shook my head at myself...
Today, on Hoarders! ... The Thread.
- Craig FarrellNever stop learning, even if it hurts. Ego bruises are practically mandatory as you learn unless you've never risked enough to make a mistake.
For better assistance in answering your questions[/url] | Forum Netiquette
For index/tuning help, follow these directions.[/url] |Tally Tables[/url]
Twitter: @AnyWayDBA -
Hi All.
Its been a while since I've been active in "the thread".
Sorry to barge in throwing you off the important subjects of phone choice and how best to hide your appointments from your wife, however I have a little dilemma and would appreciate throwing this open for the group to kick around in any way you feel may be of use.
I have to peer review a colleagues T-SQL code. Now I know how touchy people can be over having their code criticised. I mean someone peer reviewed some of my C++ recently - and, while all they said was true, it still sucks to be told!
I'd appreciate any suggestions, experiences, guidelines, or links. (And ways to prevent it ending in fisticuffs)
-
Tom Brown (10/27/2011)
Hi All.Its been a while since I've been active in "the thread".
Sorry to barge in throwing you off the important subjects of phone choice and how best to hide your appointments from your wife, however I have a little dilemma and would appreciate throwing this open for the group to kick around in any way you feel may be of use.
I have to peer review a colleagues T-SQL code. Now I know how touchy people can be over having their code criticised. I mean someone peer reviewed some of my C++ recently - and, while all they said was true, it still sucks to be told!
I'd appreciate any suggestions, experiences, guidelines, or links. (And ways to prevent it ending in fisticuffs)
Assuming you get the code and some time to review it before the face to face sit down with the colleague try to avoid saying "this section sucks", phrase your comments in a positive fashion.
For a particular area,say "Did you think of attempting ..." and if possible have a readily available reference to give to the individual. For example some of Jeff Moden's work on use of the Tally Table to handle comma delimited strings, the quirkie update, WyaneS blog posting on the handling of datetime calculations.
In cases of obscure code, say "Oh so that is what you want to do how about the inclusion of comments in the source code to explain what the code does, so that in the future if some one wants to use your code they know as much about what it does as is reasonably possible"
-
Not an easy thing to do unless there has already been a practice of peer review. That is the simple truth. We (DBA) had a tough time to make review as part of the development cycle.
What I got out of it is that praise first and advice right after it works the best way. Another trick that we used was telling them "Yes, this looks great but I think that if we change it a bit, it might work better" 😀
-Roy
-
Yes compliment first. I like it. I'm tempted to go along the lines of
"Its great. It does what its supposed to do, and it follows a self-consistant coding style."
And leave it at that, (omitting the "However ..."
... because I'll have to back up my "howevers" with some authoratative references - which means finding them, and making sure they do, in this instance, lead to better code)
Doesn't help that we have no official T-SQL coding standards, or guidelines for peer reiviews.
-
Does anyone know of a code analysis tool for T-SQL?
Perhaps there is something similar to ReSharper - the visual studio add-in.
-
Regarding Peer reviews:
- Remember the audience. Their attitude will control your approach as much as anything else.
- If you see something that seems odd, particularly strangely optimized code, simply ask them for their reasoning then if they missed an obvious ( TO YOU!) methodology, ask them if they had tried that as well and what their results were.
- Skill level will play a part in this, most II's haven't even heard of a Tally Table, nevermind the split2k.
- Discuss overall impact, and bring it outside the 'single tree'. Most peer reviews I've been involved with over the years were less because of bad coding (that's something that would usually be cured in the first month or two) but were more because you ended up hyper-focused on that task when performing the work. A fresh set of eyes brings the entire model back into play in their head, and the interconnections that the original dev may have missed.
- What you don't understand, ask. Most developers love to expound on their methods and theory. Then recommend them to put it into a comment if it's a good way so next time you see it at 2AM only one of you has to be awake. 🙂
- Try to be as gracious as you're expecting the other person to be.
-- Final, most important point: The purpose of this is to help make EVERYONE a better coder, not just the person being reviewed. I've learned a lot reviewing my better's code when I started and them having patience in the explanations.
- Craig FarrellNever stop learning, even if it hurts. Ego bruises are practically mandatory as you learn unless you've never risked enough to make a mistake.
For better assistance in answering your questions[/url] | Forum Netiquette
For index/tuning help, follow these directions.[/url] |Tally Tables[/url]
Twitter: @AnyWayDBA -
Thanks for the comments Craig
?? II's :unsure: Whats an II? (Some DBA shorthand for developers perhaps Ignorant Idiots?, Itinerant Interns? Infernal Irritants? )
Maybe I'm one as I'm not sure what the split2k is either.
-
Tom Brown (10/27/2011)
Thanks for the comments Craig?? II's :unsure: Whats an II? (Some DBA shorthand for developers perhaps Ignorant Idiots?, Itinerant Interns? Infernal Irritants? )
Maybe I'm one as I'm not sure what the split2k is either.
My guess is level 2. Between junior and senior.
-
Tom Brown (10/27/2011)
Thanks for the comments Craig?? II's :unsure: Whats an II? (Some DBA shorthand for developers perhaps Ignorant Idiots?, Itinerant Interns? Infernal Irritants? )
LOL, no, not exactly... Out of self defense, if you like, I wrote an article on it here if you want more detail on my opinions on the topic: http://www.sqlservercentral.com/articles/Career/71608/
Basically: Junior / I, Intermediate/ II, Senior/ III
Maybe I'm one as I'm not sure what the split2k is either.
Awesome piece of code used, abused, re-abused, then rebuilt from the ground up with beer popsicles and dust bunnies, with the charge led by Jeff Moden.
Check out this article by him and then the ensuing conversation: http://www.sqlservercentral.com/articles/Tally+Table/72993/
- Craig FarrellNever stop learning, even if it hurts. Ego bruises are practically mandatory as you learn unless you've never risked enough to make a mistake.
For better assistance in answering your questions[/url] | Forum Netiquette
For index/tuning help, follow these directions.[/url] |Tally Tables[/url]
Twitter: @AnyWayDBA
Viewing 15 posts - 31,246 through 31,260 (of 66,749 total)
You must be logged in to reply to this topic. Login to reply