T-SQL Code Review

Question

Post reply

T-SQL Code Review

D1rtyD0g

Ten Centuries

Points: 1045
More actions
September 15, 2008 at 1:46 am

#212572

Hi,
Can anyone point me to a site or give me some extra info on where I could get a decent SQL code review application?
I have to code review +-2500 stored procedures & it would be helpful if I can get my hands on something that will at least check the procs for coding standards while I do the logic check.
Thanks!

Viewing 8 posts - 1 through 7 (of 7 total)

You must be logged in to reply to this topic. Login to reply

PaulB-TheOneAndOnly SSC Guru Points: 66772 More actions · Answer 1

25 hundred storedprocs to review? :w00t:

yeah... that would be nice, I have to agree with you but... it won't happen.

_____________________________________
Pablo (Paul) Berzukov

Author of Understanding Database Administration available at Amazon and other bookstores.

Disclaimer: Advice is provided to the best of my knowledge but no implicit or explicit warranties are provided. Since the advisor explicitly encourages testing any and all suggestions on a test non-production environment advisor should not held liable or responsible for any actions taken based on the given advice.

Amit Khanna-455738 SSC Eights! Points: 865 More actions · Answer 2

Hi,

I think there is not any application for such task.

Even the Coding standards are company specific.

Thanks,

Amit Khanna

Harveysburger SSCommitted Points: 1562 More actions · Answer 3

I never tried it but I came across this page before

http://www.ssw.com.au/ssw/Standards/Rules/RulesToBetterSQLServerDatabases.aspx

these guys made public their standards for a bunch of things, and they made available one of the tool they wrote to help them enforcing these standards, check the page but I can't guarantee anything as I haven't tried it

let me know how it goes 🙂

Steve Jones - SSC Editor SSC Guru Points: 736129 More actions · Answer 4

Red GAte (I work for them) has SQL Refactor, which will get them consistent, but it doesn't review code.

There's not anything that can review code to see if it's done well that I'm aware of.

Matt Miller (4) SSC Guru Points: 124210 More actions · Answer 5

Agreed (not much in the way of "good" automated code review).

that being said - given the number of objects you need to review - it may be worth focusing in on the "longest running objects" and/or the most used objects first (and then the objects that they call etc....). No sense in tuning something that never or just about never gets called.

----------------------------------------------------------------------------------
Your lack of planning does not constitute an emergency on my part...unless you're my manager...or a director and above...or a really loud-spoken end-user..All right - what was my emergency again?

Harveysburger SSCommitted Points: 1562 More actions · Answer 6

yeah for the formatting SQL Refactor can help, although I find the Lay Out SQL feature could use more customizable features... but if you are happy with the way it formats your code then it's a very useful tool

Harveysburger SSCommitted Points: 1562 More actions · Answer 7

I just tried SQLAuditor.... the tool available there http://www.ssw.com.au/ssw/Standards/Rules/RulesToBetterSQLServerDatabases.aspx

It doesn't seem you can create custom rules, the tool will look through the database for violation of standards defined at SSW... you can 'uncheck' the rules that you disagree with, etc... but you can't create your own rules so this thing won't help ya